Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sync with a temp file on Windows #723

Merged
merged 1 commit into from
Jan 26, 2019

Conversation

atugushev
Copy link
Member

Fixes #722

Changelog-friendly one-liner: Fix sync with a temporary requirement file on Windows

Contributor checklist
  • Provided the tests for the changes
  • Requested (or received) a review from another contributor
  • Gave a clear one-line description in the PR (that the maintainers can add to CHANGELOG.md afterwards).

@atugushev atugushev added this to the 3.3.2 milestone Jan 25, 2019
@codecov
Copy link

codecov bot commented Jan 26, 2019

Codecov Report

Merging #723 into master will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #723      +/-   ##
==========================================
+ Coverage   85.18%   85.26%   +0.07%     
==========================================
  Files          31       31              
  Lines        2065     2076      +11     
  Branches      309      309              
==========================================
+ Hits         1759     1770      +11     
  Misses        235      235              
  Partials       71       71
Impacted Files Coverage Δ
tests/test_sync.py 98.34% <100%> (+0.13%) ⬆️
piptools/sync.py 79.38% <100%> (+0.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49efbec...82b6734. Read the comment docs.

@vphilippon vphilippon merged commit 189e936 into jazzband:master Jan 26, 2019
@atugushev atugushev deleted the fix-pyp-sync-temp-file branch February 20, 2022 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants